From b308a8bc252938f942c8b038f2d305af9b6c8fac Mon Sep 17 00:00:00 2001 From: Greg Date: Sat, 27 Mar 2021 12:26:52 +0100 Subject: [PATCH] Prevent error in getByID function --- src/main/java/one/bbn/hadder/db/Mongo.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/java/one/bbn/hadder/db/Mongo.java b/src/main/java/one/bbn/hadder/db/Mongo.java index f89916b..3706013 100644 --- a/src/main/java/one/bbn/hadder/db/Mongo.java +++ b/src/main/java/one/bbn/hadder/db/Mongo.java @@ -43,7 +43,11 @@ public class Mongo { BasicDBObject whereQuery = new BasicDBObject(); whereQuery.put(where, what); FindIterable it = collection.find(whereQuery); - return it.cursor().next().get(column); + try { + return it.cursor().next().get(column); + } catch (NoSuchElementException ignore) { + return null; + } } public JSONObject getObjectByID(String collection, String id) { @@ -133,8 +137,7 @@ public class Mongo { } public boolean hasStarboardMessage(String message_id) { - this.getByID("stars", "id", message_id, "guild"); - return true; + return this.getByID("stars", "id", message_id, "guild") != null; } public void insertStarboardMessage(String message_id, String guild_id, String starboard_message_id) {