diff --git a/src/main/java/com/bbn/hadder/commands/misc/GitHubCommand.java b/src/main/java/com/bbn/hadder/commands/misc/GitHubCommand.java index 42fa95d..906798e 100644 --- a/src/main/java/com/bbn/hadder/commands/misc/GitHubCommand.java +++ b/src/main/java/com/bbn/hadder/commands/misc/GitHubCommand.java @@ -67,12 +67,15 @@ public class GitHubCommand implements Command { event.getTextChannel().sendMessage( event.getMessageEditor().getMessage( MessageEditor.MessageType.ERROR, - "", + "commands.misc.github.api.error.title", "commands.misc.github.api.error.description") .build() ).queue(); } catch (JSONException e) { - event.getTextChannel().sendMessage(event.getMessageEditor().getMessage(MessageEditor.MessageType.WARNING, "","commands.misc.github.user.error.description").build()).queue(); + event.getTextChannel().sendMessage(event.getMessageEditor().getMessage( + MessageEditor.MessageType.ERROR, + "commands.misc.github.user.error.title", + "commands.misc.github.user.error.description").build()).queue(); } } } else { @@ -99,7 +102,7 @@ public class GitHubCommand implements Command { @Override public String usage() { - return "[GH-name]"; + return "[GH name]"; } @Override diff --git a/src/main/java/com/bbn/hadder/commands/misc/ScreenShareCommand.java b/src/main/java/com/bbn/hadder/commands/misc/ScreenShareCommand.java index 07381f7..6692306 100644 --- a/src/main/java/com/bbn/hadder/commands/misc/ScreenShareCommand.java +++ b/src/main/java/com/bbn/hadder/commands/misc/ScreenShareCommand.java @@ -16,21 +16,15 @@ public class ScreenShareCommand implements Command { @Override public void executed(String[] args, CommandEvent event) { if (args.length>0) { - if (args[0].matches("[0-9]*")&&args.length==1) { - for (VoiceChannel vc : event.getGuild().getVoiceChannels()) { - try { - if (vc.getIdLong() == Long.parseLong(args[0])) { - event.getChannel().sendMessage(event.getMessageEditor().getMessage( - MessageEditor.MessageType.INFO, - "commands.misc.screenshare.success.title", "") - .setDescription("http://discordapp.com/channels/" + event.getGuild().getId() + "/" + vc.getId() + "/").build()).queue(); - return; - } - } catch (NumberFormatException e) { - event.getChannel().sendMessage(event.getMessageEditor().getMessage(MessageEditor.MessageType.ERROR, "commands.misc.screenshare.id.error.title", "commands.misc.screenshare.id.error.description").build()).queue(); - event.getHelpCommand().sendHelp(this, event); - return; - } + if (args[0].matches("[0-9]*") && args.length==1 && args[0].length() == 18) { + if (event.getGuild().getVoiceChannelById(args[0]) != null) { + event.getChannel().sendMessage(event.getMessageEditor().getMessage( + MessageEditor.MessageType.INFO, + "commands.misc.screenshare.success.title", "") + .setDescription("http://discordapp.com/channels/" + event.getGuild().getId() + "/" + args[0] + "/").build()).queue(); + } else { + event.getChannel().sendMessage(event.getMessageEditor().getMessage(MessageEditor.MessageType.ERROR, "commands.misc.screenshare.id.error.title", "commands.misc.screenshare.id.error.description").build()).queue(); + event.getHelpCommand().sendHelp(this, event); } } else { List vcs = event.getGuild().getVoiceChannelsByName(String.join(" ", args), true); @@ -48,7 +42,6 @@ public class ScreenShareCommand implements Command { event.getChannel().sendMessage(event.getMessageEditor().getMessage(MessageEditor.MessageType.INFO, "commands.misc.screenshare.success.title", "") .setDescription("http://discordapp.com/channels/" + event.getGuild().getId() + "/" + vcs.get(i).getId() + "/").build()).queue(); } else { - event.getChannel().sendMessage(event.getMessageEditor().getMessage(MessageEditor.MessageType.ERROR, "commands.misc.screenshare.number.error.title", "").build()).queue(); event.getHelpCommand().sendHelp(this, event); } diff --git a/src/main/java/com/bbn/hadder/commands/moderation/RoleCommand.java b/src/main/java/com/bbn/hadder/commands/moderation/RoleCommand.java index de04cfd..b5049ec 100644 --- a/src/main/java/com/bbn/hadder/commands/moderation/RoleCommand.java +++ b/src/main/java/com/bbn/hadder/commands/moderation/RoleCommand.java @@ -16,8 +16,7 @@ public class RoleCommand implements Command { public void executed(String[] args, CommandEvent event) { if (args.length > 0) { if (event.getGuild().getSelfMember().hasPermission(Permission.MANAGE_ROLES)) { - String action = args[0].toLowerCase(); - switch (action) { + switch (args[0].toLowerCase()) { case "add": if (event.getMessage().getMentionedMembers().size() > 0 && event.getMessage().getMentionedRoles().size() > 0) { for (Member member : event.getMessage().getMentionedMembers()) { diff --git a/src/main/java/com/bbn/hadder/utils/MessageEditor.java b/src/main/java/com/bbn/hadder/utils/MessageEditor.java index 81b94c2..47fc105 100644 --- a/src/main/java/com/bbn/hadder/utils/MessageEditor.java +++ b/src/main/java/com/bbn/hadder/utils/MessageEditor.java @@ -113,8 +113,6 @@ public class MessageEditor { return this.handle(rethink.getLanguage(user.getId()), string, extra, extra_two); } - - private String handle(String language_code, String string, String extra, String extra_two) { Locale locale = new Locale(language_code); ResourceBundle resourceBundle = ResourceBundle.getBundle("Translations/Translations", locale); diff --git a/src/main/resources/Translations/Translations_en.properties b/src/main/resources/Translations/Translations_en.properties index fa14672..f958c88 100644 --- a/src/main/resources/Translations/Translations_en.properties +++ b/src/main/resources/Translations/Translations_en.properties @@ -70,8 +70,10 @@ commands.misc.github.success.repositories = Public repositories commands.misc.github.success.gists = Public gists commands.misc.github.success.followers = Followers commands.misc.github.success.following = Following +commands.misc.github.api.error.title = API error commands.misc.github.api.error.description = The GitHub API might be down at the moment\! -commands.misc.github.user.error.description = This user does not exist\! +commands.misc.github.user.error.title = User doesn't exist +commands.misc.github.user.error.description = I can not find a user named like this\! commands.misc.github.connect.title = Connect your GH account commands.misc.github.connect.description = [Please connect your GitHub account here]%extra% commands.misc.github.help.description = Displays information about a GitHub user profile.